[Webkit-unassigned] [Bug 120870] GTest: add support for FreeBSD and Hurd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120870


Zan Dobersek <zandobersek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zandobersek at gmail.com




--- Comment #5 from Zan Dobersek <zandobersek at gmail.com>  2013-09-06 11:42:36 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Attachment 210775 [details] [details] did not pass style-queue:
> 
> That's the second line here:
> 
> -#if (GTEST_OS_LINUX || GTEST_OS_MAC || GTEST_OS_CYGWIN || GTEST_OS_SOLARIS || \
> +#if (GTEST_OS_LINUX || GTEST_OS_FREEBSD || GTEST_OS_HURD || \
> +     GTEST_OS_MAC || GTEST_OS_CYGWIN || GTEST_OS_SOLARIS || \
>       (GTEST_OS_WINDOWS_DESKTOP && _MSC_VER >= 1400) || \
>       GTEST_OS_WINDOWS_MINGW || GTEST_OS_AIX)
> 
> I decided to keep the same spacing as the rest of the expression, I
> guess that's what makes sense here?

This is a third-party source code, so we shouldn't really enforce WebKit style guidelines in there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.