[Webkit-unassigned] [Bug 120833] [GTK] Desktop proxy settings are ignored inside the internal jhbuild

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120833


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210715|0                           |1
        is obsolete|                            |
 Attachment #210715|review?                     |
               Flag|                            |
 Attachment #210766|                            |review?
               Flag|                            |




--- Comment #7 from Mario Sanchez Prada <mario at webkit.org>  2013-09-06 10:18:02 PST ---
Created an attachment (id=210766)
 --> (https://bugs.webkit.org/attachment.cgi?id=210766&action=review)
Patch proposal

After some investigation, I realized that we can not use the trick of setting some configuration values in the memory backend from jhbuildrc (as suggested, based on the presence of the typical environment variables) because the memory backend provides in-process persistence only, and the jhbuild shell is not actually the process we are interested in, but the apps we launch in that environment (e.g. MiniBrowser), which won't read anything we set from jhbuildrc.

So, after talking to Gustavo in IRC, we believe that a better approach that will make lives easier for everybody without compromising the default configuration, would be to add dconf as an optional jhbuild module AND remove the line from jhbuildrc that explicitly sets the memory backend just for the sake of removing the usual warning you will see letting you know about that.

That way, someone willing to use the default behaviour won't have to do anything different and just will get that warning (which IMHO is useful anyway, to remind you what you are using), and someone willing to have access to the global settings will just have to run Tools/jhbuild/jhbuild-wrapper --gtk build dconf previously, pretty much as it's mentioned in https://trac.webkit.org/wiki/WebKitGTK/StartHacking#PersistentGSettings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.