[Webkit-unassigned] [Bug 120811] Get MEDIA_STREAM compiling for other ports (EFL and GTK)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120811


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210697|review?                     |review+
               Flag|                            |




--- Comment #8 from Eric Carlson <eric.carlson at apple.com>  2013-09-06 08:58:21 PST ---
(From update of attachment 210697)
View in context: https://bugs.webkit.org/attachment.cgi?id=210697&action=review

> Source/WebCore/Modules/mediastream/LocalMediaStream.h:39
> +#if PLATFORM(MAC)
>  class LocalMediaStream FINAL : public MediaStream {
> +#else
> +class LocalMediaStream : public MediaStream {
> +#endif

I think it is better to not have platform specific code here so I am fine with you just removing the FINAL.

> Source/WebCore/Modules/mediastream/RTCStatsResponse.h:46
> +#if PLATFORM(MAC)
>  class RTCStatsResponse FINAL : public RTCStatsResponseBase {
> +#else
> +class RTCStatsResponse : public RTCStatsResponseBase {
> +#endif

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.