[Webkit-unassigned] [Bug 120196] [Gtk][WK2] Use a permission-request for fullscreen requests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 08:23:12 PDT 2013


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-09-04 08:22:30 PST ---
(In reply to comment #6)
> (In reply to comment #4)
> > I think we discussed it when it was added, but I don't remember why we decided to go with enter/leave signals. Maybe martin remembers. The thing is that now that we have those signals and you can prevent fullscreen from happening using that API, I see no reason for duplicating the functionality or make it it more complex with policies.
> The problem (that I see) is that the user can't be asked on a per-request basis because to block the loading, you have to sit in the signal handler while you ask, which blocks the GUI thread.

This is a good point, permission-request api is async, I think the internal fullscreen api is sync and that's probably the reason why we decided to use the enter/leave signals

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list