[Webkit-unassigned] [Bug 120623] [CSS Background] Position property should be ignored when using repeat: space

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120623





--- Comment #8 from Andrei Parvu <parvu at adobe.com>  2013-09-03 23:36:40 PST ---
(In reply to comment #6)
> (From update of attachment 210370 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210370&action=review
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1353
> > +        if (space) {
> 
> You are not checking for positive as suggested in the ChangeLog, but for zero. Negtative values would still enter the code path.
> 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1358
> > +            geometry.setSpaceSize(FloatSize(space, 0));
> > +            geometry.setPhaseX(actualWidth ? actualWidth - roundToInt(computedXPosition + left) % actualWidth : 0);
> > +        } else
> > +            backgroundRepeatX = NoRepeatFill;
> 
> To be honest, I do not understand the code path good enough. I would have assumed that you check how many tiles fit into the paint area. If it is less than two... disable spacing and use background-position instead. Maybe the code path does it, but I don't see it. Can you elaborate more please?

getSpace() now returns -1 if the number of tiles is less than two; in this case the repeat of the image is set as NoRepeatFill. If space is greater or equal to zero, then the value of background/mask-position is ignored when computing 'computedX/YPosition'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.