[Webkit-unassigned] [Bug 117405] [EFL]Background Style of element not visible because of default theme style

Mon Sep 2 16:43:56 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=117405

--- Comment #30 from Ryuan Choi <ryuan.choi at samsung.com>  2013-09-02 16:43:13 PST ---
(From update of attachment 210282)
View in context: https://bugs.webkit.org/attachment.cgi?id=210282&action=review

> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:104
> +            if(get_int(styled) == 1) {
> +                new state[30];
> +                new Float:v;
> +                get_state(PART:"combo", state, 30, v);
> +                if(strcmp(state, "default")) {
> +                    set_state(PART:"combo", "default_styled", 0.0);
> +                    set_state(PART:"combo_button", "default_styled", 0.0);
> +                }
> +                if(strcmp(state, "disabled")) {
> +                    set_state(PART:"combo", "disabled_styled", 0.0);
> +                    set_state(PART:"combo_button", "disabled_styled", 0.0);
> +                }
> +                if(strcmp(state, "focused")) {
> +                    set_state(PART:"combo", "focused_styled", 0.0);
> +                    set_state(PART:"combo_button", "focused_styled", 0.0);
> +                }
> +                if(strcmp(state, "hovered")) {
> +                    set_state(PART:"combo", "hovered_styled", 0.0);
> +                    set_state(PART:"combo_button", "hovered_styled", 0.0);
> +                }
> +                if(strcmp(state, "pressed")) {
> +                    set_state(PART:"combo", "pressed_styled", 0.0);
> +                    set_state(PART:"combo_button", "pressed_styled", 0.0);
> +                }
> +            }

What if focused with disabled?
I think that some state may have priority.

And I hope that we have more optimized statements including previous conditions.

> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:159
>              description {
> +               state: "disabled" 0.0;
> +               inherit: "default_styled" 0.0;

s/disabled/disabled_styled ?

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:318
> +            if (haveBackground)
> +                edje_object_signal_emit(object, "styled", "");

I think this should be out of loop.

> Source/WebCore/rendering/RenderTheme.cpp:680
> +    case MenulistButtonPart:
> +        return true;

Do you really need this?

This is not EFL specific.

> LayoutTests/fast/forms/menulist_background_color_test.html:4
> +<!DOCTYPE html>
> +<html>
> +<body>
> +    <select style="background-color:green">

I think that we don't need new test case.
fast/forms/menulist-style-color.html is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.