[Webkit-unassigned] [Bug 117354] [GStreamer] Don't set state to NULL until element is destroyed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117354


Andre Moreira Magalhaes <andrunko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210140|0                           |1
        is obsolete|                            |
 Attachment #210140|review?, commit-queue?      |
               Flag|                            |
 Attachment #210293|                            |review?, commit-queue?
               Flag|                            |




--- Comment #10 from Andre Moreira Magalhaes <andrunko at gmail.com>  2013-09-02 09:23:12 PST ---
Created an attachment (id=210293)
 --> (https://bugs.webkit.org/attachment.cgi?id=210293&action=review)
Patch

(In reply to comment #9)
> (From update of attachment 210140 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210140&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:291
> > +    if (m_readyTimerHandler)
> > +        g_source_remove(m_readyTimerHandler);
> 
> Shouldn't this be done before m_playBin is cleared? Otherwise the timer might fire with an invalid player pointer?
>
Changed to remove the source before m_playBin is cleared. The change is not actually required as the timer would not be fired in the destructor (same thread and no one calling main_loop_iterate) but doesn't hurt.

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:413
> > +    // See also https://bugzilla.gnome.org/show_bug.cgi?id=117354
> 
> That bug seems quite unrelated :)
hehe, oops, fixed :)

Also rebased against upstream/master and fixed conflicts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.