[Webkit-unassigned] [Bug 103707] AssemblyHelpers::decodedCodeMapFor crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 31 13:58:54 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=103707


Michael Saboff <msaboff at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #181285|review?                     |review-
               Flag|                            |




--- Comment #20 from Michael Saboff <msaboff at apple.com>  2013-10-31 13:57:40 PST ---
(From update of attachment 181285)
View in context: https://bugs.webkit.org/attachment.cgi?id=181285&action=review

Rebase patch, make sure it builds and then resubmit for review.

> Source/JavaScriptCore/jit/JIT.cpp:754
> +/*!! begin change by linzj !!*/
> +    if (true
> +// when compiling osrExit ,the jit code map is needed for jumping.The dfg optimized code is able to jump to
> +// any base line code no matter if  it is able to be optimized.So this fix will allow jit to collect jit code map
> +// for current code block in all conditions.
> +/*!! end change by linzj !!*/

Eliminate the /*!! … !!*/ comments.
Not sure how many of the other comments are needed.  If you still think some/all of these comment need to be present, make these complete sentences beginning with a capitalized word and with a space after the '.'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list