[Webkit-unassigned] [Bug 123255] Add result caching for Math.cos

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123255





--- Comment #9 from Filip Pizlo <fpizlo at apple.com>  2013-10-31 11:49:34 PST ---
(In reply to comment #7)
> (In reply to comment #1)
> > Created an attachment (id=215035)
 --> (https://bugs.webkit.org/attachment.cgi?id=215035&action=review) [details] [details]
> > Adds result caching for Math.cos
> > 
> > A quick test consisting of averaging 5 consecutive runs of Sunspider shows a 1.9% benefit in my case.
> 
> It's customary to post full performance results to bugzilla for optimizations like these.
> 
> It's customary to run more than just SunSpider.  It's unwise to rely on a single benchmark for optimizations.  For example, Octane, JSBench, and Kraken are also important benchmarks.

Also, I cannot reproduce the speed-up that you're reporting.  I'm seeing a 0.35% difference before and after your patch and that difference is in the noise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.