[Webkit-unassigned] [Bug 122602] contentEditable deleting lists when list items are block level

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122602


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215517|review?                     |review+
               Flag|                            |




--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-30 11:20:44 PST ---
(From update of attachment 215517)
View in context: https://bugs.webkit.org/attachment.cgi?id=215517&action=review

> Source/WebCore/ChangeLog:19
> +        When listitems are styled with display:block/float then inserting paragraph twice at end
> +        of listitem delete entire list. Generally when listitem is empty then we
> +        delete the listitem on inserting paragraph. In this issue, on
> +        inserting first paragraph one empty listitem is created, and on inserting
> +        second paragraph we try to delete that empty listitem. but it misbehave becasue
> +        of incomplete definition of htmlediting::isLisItem() and entire list is deleted.
> +
> +        htmlediting::isListItem() check only render object to decide whether
> +        it is list or not, so if any LI element is block level then isListItem
> +        return false.
> +        Now after this patch if parent of current node is list element then node is
> +        treated as listItem.

Could you reformat this change log so that each line end at a similar length / at a sensible location.
e.g. ending a line with "on" is awkward.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.