[Webkit-unassigned] [Bug 123292] [GTK][WK2] Add webview signal for web-process-started

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123292





--- Comment #5 from Andre Moreira Magalhaes <andrunko at gmail.com>  2013-10-30 06:42:23 PST ---
(In reply to comment #4)
> (From update of attachment 215114 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215114&action=review
> > Source/WebKit2/UIProcess/WebContext.cpp:631
> > +WebProcessProxy* WebContext::getWebProcessForWebConnection(const WebConnection* webConnection)
> 
> How about having a method to query the pid for the remote end of the connection instead? You could have that method in the base class so you don't need to cast to WebConnectionToWebProcess. Or maybe we should go back and rethink the identifier for processes, make it a long integer like the ones used for sub resources…

Adding a processIdentifier virtual method on WebProcess would do it, but only the UIProcess (WebConnectionToWebProcess) would implement this method, so not sure. Another option would be to use a hash of WebConnection->WebProcess, this way the method (WebContext::getWebProcessForWebConnection) would be faster.

I believe using the pid is better here as we already have the info in the UIProcess, otherwise we would have to pass the identifier to the extension and UIProcess.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.