[Webkit-unassigned] [Bug 123292] [GTK][WK2] Add webview signal for web-process-started

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123292





--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2013-10-30 06:17:56 PST ---
(From update of attachment 215114)
View in context: https://bugs.webkit.org/attachment.cgi?id=215114&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3148
> +    g_signal_emit(webView, signals[WEB_PROCESS_STARTED], 0, (gpointer) &pid);

You should use a c++-style cast if it is indeed needed (static_cast<gpointer>())

> Source/WebKit2/UIProcess/WebContext.cpp:631
> +WebProcessProxy* WebContext::getWebProcessForWebConnection(const WebConnection* webConnection)

How about having a method to query the pid for the remote end of the connection instead? You could have that method in the base class so you don't need to cast to WebConnectionToWebProcess. Or maybe we should go back and rethink the identifier for processes, make it a long integer like the ones used for sub resources…

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.