[Webkit-unassigned] [Bug 112017] [EFL] accessibility/textbox-role-reports-selection.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112017


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215480|review?                     |review+
               Flag|                            |




--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-10-30 05:00:42 PST ---
(From update of attachment 215480)
View in context: https://bugs.webkit.org/attachment.cgi?id=215480&action=review

Lgtm, but it would be good if you could address those style things first

> LayoutTests/ChangeLog:7
> +

Small description here?

> Source/WebCore/ChangeLog:11
> +        No new tests, covered by existing ones.
> +
> +        getSelectionOffsetsForObject() now returns proper start/end offsets for
> +        selections "touching" the object's front border.

You probably want to swap the order of these two paragraphs

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.