[Webkit-unassigned] [Bug 122602] contentEditable deleting lists when list items are block level

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122602





--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-29 22:32:27 PST ---
(From update of attachment 215404)
View in context: https://bugs.webkit.org/attachment.cgi?id=215404&action=review

> LayoutTests/ChangeLog:13
> +        * editing/execCommand/hit-enter-twice-atendof-block-styled-listitem-expected.txt: Added.
> +        * editing/execCommand/hit-enter-twice-atendof-block-styled-listitem.html: Added.

I would have named this as inserting-paragraphs-twice instead.
Also why is atendof one word?

> LayoutTests/editing/execCommand/hit-enter-twice-atendof-block-styled-listitem-expected.txt:2
> +This test verify When hitting "Enter" twice at the end of last listitem styled with display:block/float does not cause complete list to be removed.
> +Expected behavior is list should not be removed and one extra empty line should get added.

Please fix the capitalization "When". Also I would phrase it as inserting paragraph as opposed to "hitting 'Enter'"
since this bug reproduces whenever a paragraph is inserted.

> LayoutTests/editing/execCommand/hit-enter-twice-atendof-block-styled-listitem-expected.txt:30
> +After hitting First Enter:

Why is "First Enter" capitalized?

> LayoutTests/editing/execCommand/hit-enter-twice-atendof-block-styled-listitem-expected.txt:60
> +After hitting second Enter:

Ditto about Enter.  Please at least be consistent.

> LayoutTests/editing/execCommand/hit-enter-twice-atendof-block-styled-listitem.html:20
> +        Markup.description('This test verify When hitting "Enter" twice at the end of last listitem styled with display:block/float does not cause complete list to be removed.\nExpected behavior is list should not be removed and one extra empty line should get added.');

Typo: This test *verifies* inserting two paragraphs… does not cause the entire list to be removed.
Either "verifies that the entire list is not removed when ~" or "verifies inserting paragraphs twice… does not remove the entire list".
Otherwise, the sentence doesn't make much sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.