[Webkit-unassigned] [Bug 123446] Multiple runs per line on simple line path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123446


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215389|review?                     |review+
               Flag|                            |




--- Comment #3 from Andreas Kling <akling at apple.com>  2013-10-29 08:29:53 PST ---
(From update of attachment 215389)
View in context: https://bugs.webkit.org/attachment.cgi?id=215389&action=review

r=me.

> Source/WebCore/rendering/SimpleLineLayout.cpp:263
> +        Vector<Run, 4> lineRuns;
> +        lineRuns.append(Run(lineStartOffset, 0));

This can be an uncheckedAppend() since we know there is space in the inline capacity here.

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:45
> +        Run(const Iterator&);

explicit

>> Source/WebCore/rendering/SimpleLineLayoutResolver.h:98
>> +        Iterator(RunResolver::Iterator&&);
> 
> Missing spaces around &&  [whitespace/operators] [3]

explicit

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:244
> +    rect.unite((*it).rect());

No need to declare "rect" before this line.
LayoutRect rect = (*it).rect();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.