[Webkit-unassigned] [Bug 122963] [CSSRegions] Display anonymous regions in DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 28 11:08:28 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122963


Alexandru Chiculita <achicu at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215291|review?                     |review+
               Flag|                            |




--- Comment #14 from Alexandru Chiculita <achicu at adobe.com>  2013-10-28 11:07:12 PST ---
(From update of attachment 215291)
View in context: https://bugs.webkit.org/attachment.cgi?id=215291&action=review

Thanks Mihnea!

> Source/WebCore/rendering/RenderTreeAsText.cpp:703
> +        writeIndent(ts, indent + 3);

nit: I think the +3 should happen in the caller method.

> Source/WebCore/rendering/RenderTreeAsText.cpp:715
> +                ts << " (anonymous child of)";

nit: I guess ")" should come at the end after the generated element is printed out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list