[Webkit-unassigned] [Bug 123229] Name all the GLib timeout sources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123229





--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-28 02:37:26 PST ---
(From update of attachment 215288)
View in context: https://bugs.webkit.org/attachment.cgi?id=215288&action=review

> Source/WebCore/platform/gtk/SharedTimerGtk.cpp:61
> +    g_source_set_name_by_id(sharedTimer, "[WebKit] timeout_cb");

I wonder how useful the name is in cases like this one where a generic name is used. Maybe we could use the class name SharedTimer::timeout_cb, or simply rename these callbacks to something more descriptive (in this case, it doesn't even follow the webkit style), like sharedTimerTimeoutCallback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.