[Webkit-unassigned] [Bug 123338] Re-enable simple line layout on non-Mac platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123338





--- Comment #4 from Zan Dobersek <zandobersek at gmail.com>  2013-10-26 05:34:16 PST ---
(In reply to comment #3)
> The length parameter that's passed to the TextRun constructor is then ignored, and the length of the complete string is used.

The length parameter is actually used as the xpos value rather than the length.

Anyway, enabling the 8-bit text runs works for the GTK port. Modifying the TextRun construction in the textWidth function would likely work equally well.

The 8-bit TextRun was introduced in bug #96979, but was only enabled for the Mac port because code of other platforms needed additional modifications to properly support the introduced optimization.
https://bugs.webkit.org/show_bug.cgi?id=96979#c9

The GTK port doesn't seem affected when running the tests with the support for 8-bit text runs enabled, so simply enabling the feature define would work. I'd also like to see people test out the feature on other ports and provide the proper changes so the define can be removed entirely.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.