[Webkit-unassigned] [Bug 123260] Replace 0 timeouts g_timeout_add() by g_idle_add()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 25 00:43:17 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=123260


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215146|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-25 00:42:03 PST ---
(From update of attachment 215146)
View in context: https://bugs.webkit.org/attachment.cgi?id=215146&action=review

> Source/WebCore/ChangeLog:11
> +        Patch by Bastien Nocera <hadess at hadess.net>

Why not adding the author to the changelog header so that commit-queue will credit him correctly?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5276
> -        g_timeout_add(1, cleanupTemporarilyCachedSubresources, g_list_copy(subResources));
> +        g_idle_add_full(G_PRIORITY_DEFAULT, cleanupTemporarilyCachedSubresources, g_list_copy(subResources), 0);

This is not correct, I don't know why but this was not a 0 timeout.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list