[Webkit-unassigned] [Bug 114227] Text selected with double-click gets unselected after DOM modification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 23:04:15 PDT 2013


--- Comment #32 from Santosh Mahto <santosh.ma at samsung.com>  2013-10-24 23:03:01 PST ---
(In reply to comment #31)
> (In reply to comment #30)
> > (In reply to comment #28)
> > > (From update of attachment 214981 [details] [details] [details])
> > > Attachment 214981 [details] [details] [details] did not pass mac-ews (mac):
> > > Output: http://webkit-queues.appspot.com/results/10408010
> >
> > All failed test cases has text diff in editing callbacks calls.
> > But final behavior is not changed(no diff in renderTree dump). It appears to me  extra redundant editing callback been has been removed from original test expected output.
> > 
> >  is it ok to update these expectation? or any concerns are there.
> That's the diff?  We certainly shouldn't be landing the patch as is without understanding what kind of failures we're seeing.

Ok I will debug for this failure.
One second thought i have, tests are failing after i added  newSelection.setIsDirectional(m_selection.isDirectional()); --> as your suggestion. 
This is extra update that we are pushing with this patch.
I mean this line will not effect current bug fix.
Could I remove this line for sake of this bug to be fixed without any failing tests.

Definitely we can update directionality later with another bug name and proper test case for that.(something like missing directionlity after DOM updation)
What you say??

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list