[Webkit-unassigned] [Bug 123111] Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123111


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214782|review?                     |review+
               Flag|                            |




--- Comment #6 from Timothy Hatcher <timothy at apple.com>  2013-10-24 14:03:21 PST ---
(From update of attachment 214782)
View in context: https://bugs.webkit.org/attachment.cgi?id=214782&action=review

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:256
> +    Page* page = core(m_webView);
> +    if (page) {
> +        page->inspectorController()->disconnectFrontend();
> +    }

Could put Page* page in the if() and drop the { }.

> Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h:38
> +#define WIRSimulatorTCPPortNumber               27753
> +#define WIRXPCMachPortName                      "com.apple.webinspector"
> +#define WIRServiceAvailableNotification         "com.apple.webinspectord.available"
> +#define WIRServiceAvailabilityCheckNotification "com.apple.webinspectord.availability_check"
> +#define WIRServiceEnabledNotification           "com.apple.webinspectord.enabled"
> +#define WIRServiceDisabledNotification          "com.apple.webinspectord.disabled"

These could be const NSString * instead. Also there isn't any reason for the symbol to keep the "WIR" prefix, it could differ even if the string content needs to keep "WIR".

> Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm:281
> +    NSString *connectionIdentifier = [dictionary objectForKey:WIRConnectionIdentifierKey];
> +    [self pushListing:connectionIdentifier];

One line?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.