[Webkit-unassigned] [Bug 107301] methods on window.internals shouldn't pass in a document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107301


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215084|review?                     |review+
               Flag|                            |




--- Comment #16 from Alexey Proskuryakov <ap at webkit.org>  2013-10-24 13:29:40 PST ---
(From update of attachment 215084)
View in context: https://bugs.webkit.org/attachment.cgi?id=215084&action=review

> Source/WebCore/ChangeLog:11
> +        Each 'Internals' instance is associated with a 'Document'. So, it
> +        is not necessary to pass a document as argument. Only nodesFromRect and
> +        layerTreeAsText methods were kept because, in some Layout Tests, the
> +        'Document' object is not the same used by Internals::contextDocument.

Can you add comments in these functions explaining why they take the document argument?

> Source/WebCore/ChangeLog:13
> +        No new tests.

No reason to add this line, it's pretty obvious to anyone who would care why there are no new tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.