[Webkit-unassigned] [Bug 123260] Replace 0 timeouts g_timeout_add() by g_idle_add()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 24 06:29:52 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=123260


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215047|review?                     |review-
               Flag|                            |




--- Comment #6 from Anders Carlsson <andersca at apple.com>  2013-10-24 06:28:37 PST ---
(From update of attachment 215047)
View in context: https://bugs.webkit.org/attachment.cgi?id=215047&action=review

Patch looks good but needs a ChangeLog with the rationale.

>> Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp:94
>> +                                                   const_cast<void*>(static_cast<const void*>(this)), 0);
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

I know you're just matching what was here before, but the entire function call should be on a single line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list