[Webkit-unassigned] [Bug 122967] [GTK] Removing flags for tests fixed in bug 121828

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122967





--- Comment #9 from Javier Fernandez <jfernandez at igalia.com>  2013-10-24 02:30:08 PST ---
(In reply to comment #7)
> (From update of attachment 214993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214993&action=review
> 
> Informal review.
> 
> > LayoutTests/ChangeLog:3
> > +        Removing flags for tests fixed in bug 121828
> 
> I'd add [GTK] here, as the patch only affects to the GTK+ port.

I'll do.

> 
> > LayoutTests/ChangeLog:8
> > +        * platform/gtk-wk2/TestExpectations:
> 
> You're not modifying this file so it shouldn't appear in the ChangeLog.
> 

Yes, I'll change that.

> > LayoutTests/platform/gtk/TestExpectations:47
> >  webkit.org/b/121828 fast/repaint/region-painting-via-layout.html [ Missing ]
> 
> There're 3 more tests related to bug #121828, why don't remove all of them from TestExpectations file and provide new baselines if required?

Those 3 additional tests, supposedly passing because of bug 121828 has been already fixed, haven't got any expected result file, and I'm not confident enough to include the one generated by my build.

I think it would be better to keep them flagged, for the time being.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.