[Webkit-unassigned] [Bug 123229] Timeout related bug fixes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123229





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-24 00:57:56 PST ---
(From update of attachment 215007)
View in context: https://bugs.webkit.org/attachment.cgi?id=215007&action=review

We don't use usually attach more than one patch to the same bug report, could you please file a new bug report and upload an updated patch with the style issues fixed please? You can run Tools/Scripts/check-webkit-style script to make sure your patch doesn't have style issues before uploading them. Also, if you ask for review, setting the review flag to ?, the style bot will also run the style checker for you.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:415
> +        g_source_set_name_by_id (m_readyTimerHandler, "[WebKit] mediaPlayerPrivateReadyStateTimeoutCallback");

WebKit coding style doesn't allow space between function name and parentheses.

> Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp:319
> +        guint id;
> +        id = g_timeout_add_seconds(timeoutSeconds, waitToDumpWatchdogFired, 0);

Use a single line here.

> Tools/MiniBrowser/gtk/BrowserWindow.c:164
> +        guint id;
> +        id = g_timeout_add(500, (GSourceFunc)resetEntryProgress, window->uriEntry);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.