[Webkit-unassigned] [Bug 123170] Keyframe animations do multiple style recalcs before starting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 23 16:42:02 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=123170





--- Comment #6 from Ralph T <ralpht+bugs at gmail.com>  2013-10-23 16:40:47 PST ---
I switched to using a layer flush mechanism based on my runloop (Glib for me), more like mac, and now I don't need an explicit flush to get animations to the UIProcess early.

The remaining change causes a new keyframe animation to be emitted to the GraphicsLayer on the first style recalc rather than the second.

I validated that it doesn't break accelerated and unaccelerated animations by commenting out the call from the compositor to GraphicsLayerClient::notifyAnimationStarted -- the consequence of this was that the unaccelerated animation never started as expected and this behavior was the same with or without the patch (and neither generated a webkitAnimationStart event).

I don't believe there is any behavior change caused by this patch except that the animation is emitted earlier. All of the slow animation LayoutTests pass. What else can I test/validate?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list