[Webkit-unassigned] [Bug 123144] [GTK] enable media-stream in build-webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123144


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214826|review?                     |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-10-23 13:07:18 PST ---
(From update of attachment 214826)
View in context: https://bugs.webkit.org/attachment.cgi?id=214826&action=review

I'm okay with enabling media stream for build-webkit, but let's not add a configure flag.

> Source/autotools/ReadCommandLineArguments.m4:133
> +AC_MSG_CHECKING([whether to enable media stream support])
> +AC_ARG_ENABLE(media_stream, 
> +    AC_HELP_STRING([--enable-media-stream], [enable media stream support (incomplete) [default=no]]),
> +    [],
> +    [enable_media_stream="no"])
> +AC_MSG_RESULT([$enable_media_stream])
> +

I don't think we actually need a configuration flag for this. It's incomplete and we don't typically add flags for web features. The existing flags are exceptions to this rule.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.