[Webkit-unassigned] [Bug 114227] Text selected with double-click gets unselected after DOM modification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 23 11:02:52 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114227





--- Comment #21 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-23 11:01:38 PST ---
(From update of attachment 214701)
View in context: https://bugs.webkit.org/attachment.cgi?id=214701&action=review

>>> Source/WebCore/editing/FrameSelection.cpp:463
>>> +        if (base != extent || !m_selection.isRange())
>> 
>> Where did !m_selection.isRange() come from?
> 
> I was trying to put better check here. 
> In case of caret selection also base == range. So in case of caret selection i wanted to use selection update by base/extent.
> 
> I mean i wanted to update the selection by start/end only if base == extent and its range selection.
> 
> Isn't it ok??

But why?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list