[Webkit-unassigned] [Bug 112890] NRWT: --force should run tests as if they're expected to pass

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112890





--- Comment #16 from Csaba Osztrogonac <ossy at webkit.org>  2013-10-23 01:53:28 PST ---
(From update of attachment 214736)
View in context: https://bugs.webkit.org/attachment.cgi?id=214736&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:341
> +    if options.force and options.skipped not in ('ignore', 'default'):
> +        _log.warning("--force overrides --skipped=%s" % (options.skipped))
> +        options.skipped = 'ignore'
> +

It seems the bug is here. After this change --force makes NRWT run
[ Failure ] marked tests if they marked as [ Pass ], but it doesn't
run [ Skip ] and [ WontFix ] marked tests as they pass.

The problem is that options.skipped = 'default' by default,
but it should be 'ignore' if options.force is true.

Tamás, please run Tools/Scripts/test-webkitpy unit tests next time
you touches webkitpy codes.

I thought CQ bots run webkitpy tests ... but it seems they don't.
I found this: "# FIXME: We should teach the commit-queue and the EWS how to run these tests."
in Tools/Scripts/webkitpy/tool/steps/runtests.py

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.