[Webkit-unassigned] [Bug 123111] Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123111





--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org>  2013-10-21 14:46:23 PST ---
Attachment 214782 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FeatureDefines.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Configurations/FeatureDefines.xcconfig', u'Source/WebCore/WebCore.exp.in', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Configurations/FeatureDefines.xcconfig', u'Source/WebKit/mac/Misc/WebKitLogging.h', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/FeatureDefines.xcconfig']" exit_code: 1
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:89:  The parameter name "remoteChannel" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h:39:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h:42:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/mac/ChangeLog:83:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WTF/wtf/FeatureDefines.h:873:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 9 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.