[Webkit-unassigned] [Bug 123025] MediaStreamTrack now tracks its own state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123025





--- Comment #2 from Jer Noble <jer.noble at apple.com>  2013-10-21 12:44:00 PST ---
(From update of attachment 214581)
View in context: https://bugs.webkit.org/attachment.cgi?id=214581&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:80
> +    m_state = m_source ? (TrackState) m_source->readyState() : MediaStreamTrack::New;

The space between the cast and variable is unnecessary, but I'm more worried about the cast itself.  There should only be one instance of this enum, either in MediaStreamTrack, or MediaStreamSource.

So, if you reverted the m_readyState -> m_state change, removed the MediaStreamTrack::TrackState enum, and kept the new setState() method (but renamed it setReadyState()), this patch would be a lot simpler.

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:307
> +    setState((TrackState) m_source->readyState());

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.