[Webkit-unassigned] [Bug 120998] [Win] Compile errors when enabling DFG JIT.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120998





--- Comment #17 from peavo at outlook.com  2013-10-21 10:43:59 PST ---
> I think this looks fine. I had a couple of questions I wanted to check with you about before approving it.
> 
> > Source/JavaScriptCore/dfg/DFGAllocator.h:81
> > +    void startBumpingIn(Region*);
> 
> I don't understand why we are removing the scoping here. Is this to silence a warning in Visual Studio?
> 

It was actually a compiler error. I don't remember the exact error right now, but can look it up :)

> > Source/JavaScriptCore/jit/JITOperationWrappers.h:332
> > +__declspec(naked) EncodedJSValue JIT_OPERATION function(ExecState*, EncodedJSValue, StringImpl*) \
> 
> These macros are going to be hard to replicate for 64-bit with Visual Studio since it prohibits inline assembly.
> 
> > Source/WTF/wtf/CompilationThread.cpp:55
> > +    initializeCompilationThreadsMutex.unlock();
> 

Ok, I see, so we need to create an .asm file for this for 64-bit?

> We should probably create a WTF/ThreadingOnce.h/.cpp that encapsulates this pattern.  We use the pthread_once logic in a number of places, and it would be useful to only do this one way throughout our code base.
> 
> You don't need to do that in this bug, of course :-)

Good point, I can look into this in a separate bug :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.