[Webkit-unassigned] [Bug 114227] Text selected with double-click gets unselected after DOM modification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114227





--- Comment #20 from Santosh Mahto <santosh.ma at samsung.com>  2013-10-21 08:31:16 PST ---
(In reply to comment #19)
> (From update of attachment 214701 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214701&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        same) and DOM is modified then selection gets vanished, this does not
> > +        happen when selection is done by dragging mouse. This happens because
> 
> This is a run-on sentence. Please either end the first sentence "~gets vanished" with a period or a semicolon.
> 
> > Source/WebCore/ChangeLog:21
> > +        (WebCore::FrameSelection::textWasReplaced): use start/end to update
> > +        selection in case double click selection.
> 
> We need a better description as so why we check base != extent, etc...
Will take care of this. thanks

> > Source/WebCore/editing/FrameSelection.cpp:463
> > +        if (base != extent || !m_selection.isRange())
> 
> Where did !m_selection.isRange() come from?
I was trying to put better check here. 
In case of caret selection also base == range. So in case of caret selection i wanted to use selection update by base/extent.

I mean i wanted to update the selection by start/end only if base == extent and its range selection.

Isn't it ok??

> > Source/WebCore/editing/FrameSelection.cpp:465
> > +        else if (m_selection.isDirectional() && !m_selection.isBaseFirst())
> 
> This is not want I meant. I meant that you need to do newSelectino.setIsDirectional(m_selection.isDirectional());

I got. yeah this should be done. Thanks for pointing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.