[Webkit-unassigned] [Bug 114227] Text selected with double-click gets unselected after DOM modification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 20 16:41:12 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114227





--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-20 16:39:57 PST ---
(From update of attachment 214701)
View in context: https://bugs.webkit.org/attachment.cgi?id=214701&action=review

> Source/WebCore/ChangeLog:10
> +        same) and DOM is modified then selection gets vanished, this does not
> +        happen when selection is done by dragging mouse. This happens because

This is a run-on sentence. Please either end the first sentence "~gets vanished" with a period or a semicolon.

> Source/WebCore/ChangeLog:21
> +        (WebCore::FrameSelection::textWasReplaced): use start/end to update
> +        selection in case double click selection.

We need a better description as so why we check base != extent, etc...

> Source/WebCore/editing/FrameSelection.cpp:463
> +        if (base != extent || !m_selection.isRange())

Where did !m_selection.isRange() come from?

> Source/WebCore/editing/FrameSelection.cpp:465
> +        else if (m_selection.isDirectional() && !m_selection.isBaseFirst())

This is not want I meant. I meant that you need to do newSelectino.setIsDirectional(m_selection.isDirectional());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list