[Webkit-unassigned] [Bug 123056] DFG dominators: Fix a bug and document.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123056





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2013-10-18 23:06:21 PST ---
(From update of attachment 214638)
View in context: https://bugs.webkit.org/attachment.cgi?id=214638&action=review

> Source/JavaScriptCore/dfg/DFGDominators.cpp:107
> +    m_scratch.clearAll();
> +
> +    // Find the intersection of dom(preds).
>      m_scratch.set(m_results[block->predecessors[0]->index]);

I'm actually not sure I understand the difference.  FastBitVector::set(const FastBitVector&) is a memcpy().

Hence, the clearAll() call appears to be a no-op.

I agree with the way you restructured the code, though.  It seems that the best thing to do is to drop the clearAll() call and rename set() to something like copyFrom(), to make it clear that it's a copy rather than a bitwise '|=' .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.