[Webkit-unassigned] [Bug 122458] Simple line layout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122458





--- Comment #30 from Antti Koivisto <koivisto at iki.fi>  2013-10-18 10:57:03 PST ---
> > Source/WebCore/dom/Position.cpp:650
> > +            textRenderer->ensureInlineBoxes();
> 
> It's unclear how callers can know that they should call ensureInlineBoxes()

They won't eventually. It just signals that I haven't fixed the code to work with simple layout yet.

> > Source/WebCore/rendering/RenderText.cpp:283
> > +    // FIXME: These will go away when simple layout can do everything.
> 
> But then it will no longer be simple?

It will still be simple. "Simple" refers to the fact that it does not support full rendering model. For the parts that it does support it should do everything. Currently the missing piece is selection painting and some editing details.

> Shame we can't turn m_lineBoxes into some virtual thing that does both.

Are you planning to add another line layout mode?

> > Source/WebCore/rendering/ResolvedSimpleLines.h:38
> > +class ResolvedSimpleLines {
> 
> The "resolved" doesn't really communicate anything I think.

It communicates that these are resolved lines. Data structures (SimpleLineLayout::Line) are kept unresolved to save space. Line rects and baselines are resolved on demand.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.