[Webkit-unassigned] [Bug 120998] [Win] Compile errors when enabling DFG JIT.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 17 06:49:59 PDT 2013


--- Comment #11 from peavo at outlook.com  2013-10-17 06:48:44 PST ---
(In reply to comment #8)
> (From update of attachment 213241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213241&action=review
> Looks good!  I'll try it locally. I notice you don't activate DFG -- is that because the implementation is still not right?
> > Source/JavaScriptCore/jit/JITOperationWrappers.h:310
> > +#elif COMPILER(MSVC) && CPU(X86)
> Unfortunately, none of this can be easily used for 64-bit builds because MSVC does not allow in-line assembly code. We are going to have to move this code to an *.asm file at some point.

Thanks for looking into this :)

I believe there are a couple of issues which needs to be fixed before DFG can be activated. There is bug 121001, which should fix a crash with generated code. Also the file wtf/CompilationThread.cpp needs to add code for platforms which doesn't use pthreads. I guess we can quickly whip up something there :) When I tested it, I enabled pthreads locally, so I didn't have to change this code. With those two changes in place, it seemed to work well, I got another JSC related crash after leaving the computer idle for awhile, but this was a simple NULL pointer crash, which we should be able to sort out :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list