[Webkit-unassigned] [Bug 122862] Add ftlShouldBe() function to test FTL jitted code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122862





--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2013-10-15 14:13:00 PST ---
(From update of attachment 214298)
View in context: https://bugs.webkit.org/attachment.cgi?id=214298&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2911
> +    return JITCode::isOptimizingJITFTL(replacement()->jitType());

I would just say replacement()->jitType() == JITCode::FTLJIT;

> Source/JavaScriptCore/jit/JITCode.h:149
> -    
> +
> +    static bool isOptimizingJITFTL(JITType jitType)
> +    {
> +        return jitType == FTLJIT;
> +    }
> +

Don't need this.  It would only be useful if we planned to add a fifth tier or something. ;-)

> LayoutTests/resources/standalone-pre.js:265
> +function ftlCompiled(argument)
> +{
> +    if (!("f" in argument))
> +        throw new Error("ftlCompiled called with invalid argument.");
> +    return testRunner.compiledByFTL(argument.f);
> +}

What happens if this runs in run-webkit-tests?  Do you have logic to stub out compiledByFTL()?  I don't see the logic to wire compiledByFTL into the DumpRenderTree or WebKitTestRunner testRunner's.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.