[Webkit-unassigned] [Bug 122787] JavaScriptCore tests should run on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122787





--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2013-10-14 16:29:57 PST ---
(In reply to comment #0)
> JavaScriptCore tests haven't run on Windows, and the Win64 JavaScriptCore is broken.  To help us fix this, I'm making the tests work again.  The 64-bit tests still don't work, but this is a step in the right direction.

Wonderful!

> I was getting "application unable to start correctly (0xc0000022)" errors when WTF and JavaScriptCore were built separately, and the JavaScriptCore.submit.sln wasn't building any of the LLint projects, so I fixed that.

Great!

> I also copy the necessary dlls to the right places to run JavaScriptCore tests.  It's a bit unconventional to copy into Source, but actual.html is written there already.  Reviewers might not like that.  This solution works and it doesn't mess with the mozilla jsDriver.pl.  Otherwise we'd need to do strange things with the working directory on windows and importing webkitdirs.pm.

No!

This is exactly why we have the DLLLauncher.cpp stuff that looks for the AAS install.  We have to make sure that the necessary runtime libraries supporting WebKit are available.

Your other option would be to modify the PATH environment variable to include the project file output so that the programs will run.

Copying files into the tree is a non-starter!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.