[Webkit-unassigned] [Bug 122097] ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122097


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214148|review?                     |review-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-14 09:32:08 PST ---
(From update of attachment 214148)
View in context: https://bugs.webkit.org/attachment.cgi?id=214148&action=review

> Source/WebCore/ChangeLog:25
> +        (WebCore::StyleChange::extractTextStyles): Remove property even if 
> +        it is declared !important.

Why?

> Source/WebCore/editing/EditingStyle.cpp:1446
> -        setTextDecorationProperty(style, newTextDecoration.get(), CSSPropertyTextDecoration);
> +        if (newTextDecoration->length())
> +            setTextDecorationProperty(style, newTextDecoration.get(), CSSPropertyTextDecoration);
> +        else
> +            style->removeProperty(CSSPropertyTextDecoration);
> +

This doesn't make any sense. The whole point of setTextDecorationProperty is to take care of that.
We should figure out why setTextDecorationProperty has the assertion instead of working around it here.

> LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe.html:6
> +    <iframe onload=" {     document.designMode=&apos;on&apos;;
> +                   document.execCommand(&apos;selectall&apos;);
> +                   document.execCommand(&apos;RemoveFormat&apos;);      } ">

Please fix the indentation.
Also, we should use dump-as-text or dump-as-markup.
There is no reason for this test to be a render tree dump.
r- because of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.