[Webkit-unassigned] [Bug 97516] [CMake] Remove support for cmake version < 2.8.3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97516





--- Comment #8 from Afonso Costa <afonso.costa at samsung.com>  2013-10-14 08:15:10 PST ---
(In reply to comment #7)
> (From update of attachment 214018 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214018&action=review
> 
> >>>> Source/cmake/FindCairo.cmake:-78
> >>>> -endif ()
> >>> 
> >>> I am not sure.
> >>> With this patch, find_package(Cairo 999.10.2 REQUIRED) is fine.
> >> 
> >> This review comment isn't clear for me. Currently we use "Cairo 1.10.2" for EFL and GTK ports. Do you mean this patch will not support 999.10.2 version style ?
> > 
> > I mean that FindCairo.cmake will not complain with this pacth although find_package requests higher version than current version which system have.
> > 
> > 999.10.2 is just one of example, which is higher version than currently installed.
> > 
> > I think that FindCairo.cmake should raise assert when find_package request higer version.
> 
> Ok, I see. This patch can't generate compilation fail when higher version is required. This patch should check if higher version is required.


Hi Ryuan and Gyuyoung,

thanks for review.

I've updated the patch according to your suggestions. But, I have one doubt yet: are the changes in the other files ok for you or do I need to make the check also?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.