[Webkit-unassigned] [Bug 122722] Make absoluteQuads/Rects functions return Vectors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122722


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214095|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-10-13 03:55:40 PST ---
(From update of attachment 214095)
View in context: https://bugs.webkit.org/attachment.cgi?id=214095&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

OOPS!

> Source/WebCore/dom/Range.cpp:1944
> +                Vector<FloatQuad> textQuads = renderText.absoluteQuadsForRange(startOffset, endOffset);

Could use auto for this.

> Source/WebCore/dom/Range.cpp:1947
>                  quads.appendVector(textQuads);

Sidenote: I wonder if an appendVector(Vector&&) would be a useful optimization.

> Source/WebCore/rendering/RenderText.cpp:261
>  void RenderText::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const

I wish this method were called collectAbsoluteRects() or something like that.
Same whine for the other similarly named ones.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.