[Webkit-unassigned] [Bug 122546] Web Inspector: inspector forgets open navigation sidebar when re-opening

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 10 11:47:52 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122546


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213897|review?                     |review+
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at apple.com>  2013-10-10 11:46:41 PST ---
(From update of attachment 213897)
View in context: https://bugs.webkit.org/attachment.cgi?id=213897&action=review

Looks good. Just some style nits.

> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:86
> +        var representedObject = (cookie.url) ? this.resourceForURL(cookie.url) : this.mainFrame;

No need for ( ).

> Source/WebInspectorUI/UserInterface/StorageManager.js:159
> +            return (matchOnTypeAlone && array.length) ? array[0] : null;

No need for ( ).

> Source/WebInspectorUI/UserInterface/StorageManager.js:179
> +        if (cookie.type === WebInspector.ContentViewCookieType.DOMStorage)
> +            return findMatchingObjectInArray(this._domStorageObjects, function(object) {
> +                return object.host === cookie.host && object.isLocalStorage() === cookie.isLocalStorage;
> +            });

This needs { } since it is multi-line.

> Source/WebInspectorUI/UserInterface/StorageManager.js:184
> +        if (cookie.type === WebInspector.ContentViewCookieType.Database)
> +            return findMatchingObjectInArray(this._databaseObjects, function(object) {
> +                return object.host === cookie.host && object.name === cookie.name;
> +            });

Ditto.

> Source/WebInspectorUI/UserInterface/StorageManager.js:192
> +        if (cookie.type === WebInspector.ContentViewCookieType.DatabaseTable)
> +            return findMatchingObjectInArray(this._databaseObjects, function(object) {
> +                return object.host === cookie.host && object.database === cookie.name;
> +            });

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list