[Webkit-unassigned] [Bug 122142] Release expired pages in the page cache more often

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122142





--- Comment #5 from Zalan Bujtas <zalan at apple.com>  2013-10-10 09:30:53 PST ---
(From update of attachment 213862)
View in context: https://bugs.webkit.org/attachment.cgi?id=213862&action=review

> Source/WebCore/history/HistoryItem.cpp:254
> +    if (!m_expirationTimer->isActive())

Wouldn't be better to assert this? Calling startExpirationTimer() multiple times without calling stop() could indicate defective behaviour. The patch in current form would ignore that and probably release the history item sooner than it is intended (because in PageCache::add(), we recreate CachedPage object so item->m_cachedPage has a new expiration time now, and when we try to (re)start the timer (item->startExpirationTimer()), it sees it as active and fails to reset it to the new expiration timestamp.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.