[Webkit-unassigned] [Bug 122467] Modify WTF and JavascriptCore makefiles for 64bit build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122467





--- Comment #3 from Roger Fong <roger_fong at apple.com>  2013-10-07 15:13:32 PST ---
(In reply to comment #2)
> (From update of attachment 213618 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213618&action=review
> 
> r=me with one suggestion before you land.
> 
> > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.make:36
> > +    set Path=%PATH%;$(SRCROOT)\%ProgramFilesAAS%
> 
> It seems like this %PATH% will contain the 32-bit path from line 12/14 above. Should we use a separate value here? Or maybe hold onto the original PATH (pre-changing in 12/14) with a different name, like "set OrigPath=%PATH%", then here do "Set Path=%OrigPath%;$(SRCROOT)...etc."
> 
> > Source/WTF/WTF.vcxproj/WTF.make:26
> > +    set Path=%PATH%;$(SRCROOT)\%ProgramFilesAAS%
> 
> Ditto regarding path from above. Might want to retain original path in a separate variable, then use it here so we don't get the 32-bit path before our 64-bit stuff.


O yup, you're right, will change. Although this brings up another question which is why we need the path at all. I suppose it was useful when JavaScriptCore used JavaScriptCoreGenerator.exe. 
Perhaps it's useful to have it there though just in case any executable steps get added to the build steps in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.