[Webkit-unassigned] [Bug 122156] [Tools] Add the check to style-checker for reporting use of static_cast on typename objects.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 10:37:21 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122156





--- Comment #8 from Ravi Kasibhatla <r.kasibhatla at samsung.com>  2013-10-07 10:36:12 PST ---
(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 213079 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=213079&action=review
> > 
> > > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:780
> > > +        self.assertEqual(message, 'static_cast of class objects is not allowed. Use toFoo defined in Foo.h.'
> > 
> > This message is not clear. What are "class objects"?
> > 
> > > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:789
> > > +        self.assertEqual(message, 'static_cast of class objects is not allowed. Add toFoo in Foo.h and use it instead.'
> > 
> > Ditto.
> Done.
Thoughts on the patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list