[Webkit-unassigned] [Bug 120769] [CSS Regions] Selection focusNode set to the "region" block, instead of the "source" block

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 09:21:34 PDT 2013


--- Comment #12 from Radu Stavila <stavila at adobe.com>  2013-10-07 09:20:25 PST ---
(From update of attachment 213166)
View in context: https://bugs.webkit.org/attachment.cgi?id=213166&action=review

>> Source/WebCore/rendering/RenderRegion.cpp:68
>> +    LayoutPoint newPoint(0, point.y());
> The approach here of computing a point within the flow thread portion rect seems peculiar to me.

No point in initialising newPoint's y with point.y() since you're going to override it by calling newPoint.setY(...) in all cases.

> Source/WebCore/rendering/RenderRegion.cpp:77
> +        return toRenderBlock(m_flowThread->firstChild())->positionForPoint(newPoint);

I think you should perform the firstChild() check before computing newPoint because you could end up computing it for nothing (since you're not using it if firstChild() == 0).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list