[Webkit-unassigned] [Bug 122433] Factor text paint style computation out from InlineTextBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122433


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213547|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-10-06 18:13:18 PST ---
(From update of attachment 213547)
View in context: https://bugs.webkit.org/attachment.cgi?id=213547&action=review

> Source/WebCore/rendering/TextPaintStyle.cpp:38
> +TextPaintStyle::TextPaintStyle()

I would zero-initialize the stroke width here for good measure.

> Source/WebCore/rendering/TextPaintStyle.h:54
> +void updateGraphicsContext(GraphicsContext*, const TextPaintStyle&, StrokeColorType = UseNormalStrokeColor);

This should take a GraphicsContext&.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.