[Webkit-unassigned] [Bug 122305] [GTK] Enable text edition UndoOperations support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122305





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-04 00:11:03 PST ---
(From update of attachment 213314)
View in context: https://bugs.webkit.org/attachment.cgi?id=213314&action=review

Looks good to me in general, I have just a few minor comments. Thanks!

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:31
> +#include "DefaultUndoController.h"

This is already included in PageClientImpl.h

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:41
> +class DefaultUndoController;

Do we really need this? We are already including the header here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:375
> -    priv->pageClient = PageClientImpl::create(viewWidget);
> +    priv->pageClient = PageClientImpl::create(viewWidget, &priv->undoController);

Wouldn't it be simpler to make DefaultUndoController a member of PageClientImpl? The undocontroller is not used by the WebKitWebViewBase at all

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.