[Webkit-unassigned] [Bug 122154] [Tools] User interruption (Ctrl+C) on run-webkit-tests should also generate results.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122154





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-03 01:21:55 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:83
> > > +    # We need to still handle KeyboardInterrupt, atleast for webkitpy unittest cases.
> > 
> > Type: at least
> Done. Corrected.
> > 
> > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:960
> > > -            self.assertEqual(res, run_webkit_tests.INTERRUPTED_EXIT_STATUS)
> > > +            self.assertEqual(res, INTERRUPTED_EXIT_STATUS)
> > 
> > We need an assertion to make sure results.html is generated. 
>
> How can we test for results.html in this unit test case - because it is not generated. Before start of this test case, we change the run() func pointer to point to a dummy run() which just raises the KeyboardInterrupt. So, in the testcase, we don't even read the test expectations to generate results json file, so no results.html. The only way to test for results.html generation is to run at least 1 actual test and then check for the file presence.

There are tests for generating results.html.  Please take a look at them and add a new test case.

> What other tests do you intend to see?

I don't think we need multiple test cases for this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.